Fix memo (#68)

- delete memo (9e941ac4e56b7b77ec77b84a3a40130ba78a9511)
- Updated memo (42a5122528ae84ba3bed9679869a4386ea004b8f)
- add test logs, format and bumped version (d423cf4c52af795084bde064f4db385aa33d8267)

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
+## [v1.2.0] - 2025-06-23
+
+### Fixed
+
+- Updated the memo dataset, this second version fixed previous [issues](https://huggingface.co/datasets/danish-foundation-models/danish-dynaword/discussions/67) with the download and processing of the Danish Memo which cut off the text leading to notably smaller documents.
+
 ## [v1.1.1] - 2025-06-16
 
 ### Added

README.md

@@ -174,7 +174,7 @@ https://github.com/huggingface/datasets/blob/main/templates/README_guide.md
 <!-- START README TABLE -->
 |              |                                                                                                                                                             |
 | ------------ | ----------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| **Version** | 1.1.1 ([Changelog](/CHANGELOG.md)) |
+| **Version** | 1.2.0 ([Changelog](/CHANGELOG.md)) |
 | **Language** | dan, dansk, Danish                                                                                                                                          |
 | **License**  | Openly Licensed, See the respective dataset                                                                                                                 |
 | **Models**   | For model trained used this data see [danish-foundation-models](https://huggingface.co/danish-foundation-models)                                            |
@@ -206,15 +206,14 @@ https://github.com/huggingface/datasets/blob/main/templates/README_guide.md
   - [License information](#license-information)
     - [Personal and Sensitive Information](#personal-and-sensitive-information)
     - [Notice and takedown policy](#notice-and-takedown-policy)
-  - [We will comply with legitimate requests by removing the affected sources from the next release of the corpus](#we-will-comply-with-legitimate-requests-by-removing-the-affected-sources-from-the-next-release-of-the-corpus)
 
 ## Dataset Description
 
 <!-- START-DESC-STATS -->
 - **Language**: dan, dansk, Danish
-- **Number of samples**: 891.08K
-- **Number of tokens (Llama 3)**: 4.26B
-- **Average document length (characters)**: 14755.73
+- **Number of samples**: 891.09K
+- **Number of tokens (Llama 3)**: 4.37B
+- **Average document length (characters)**: 15086.31
 <!-- END-DESC-STATS -->
 
 
@@ -312,43 +311,43 @@ This data generally contains no annotation besides the metadata attached to each
 Below follows a brief overview of the sources in the corpus along with their individual license.
 
 <!-- START-MAIN TABLE -->
-| Source              | Description                                                                                                                                                       | Domain       | N. Tokens   | License                |
-|:--------------------|:------------------------------------------------------------------------------------------------------------------------------------------------------------------|:-------------|:------------|:-----------------------|
-| [cellar]            | The official digital repository for European Union legal documents and open data                                                                                  | Legal        | 1.15B       | [CC-BY-SA 4.0]         |
-| [ncc_books]         | Danish books extracted from the [Norwegian Colossal Corpus](https://huggingface.co/datasets/NbAiLab/NCC) derived from OCR                                         | Books        | 531.97M     | [CC-0]                 |
-| [retsinformationdk] | [retsinformation.dk](https://www.retsinformation.dk) (legal-information.dk) the official legal information system of Denmark                                      | Legal        | 516.35M     | [Danish Copyright Law] |
-| [hest]              | Samples from the Danish debate forum www.heste-nettet.dk                                                                                                          | Social Media | 389.32M     | [CC-0]                 |
-| [ncc_parliament]    | Collections from the Norwegian parliament in Danish. Extracted from the [Norwegian Colossal Corpus](https://huggingface.co/datasets/NbAiLab/NCC) derived from ocr | Other        | 338.87M     | [NLOD 2.0]             |
-| [opensubtitles]     | Danish subsection of [OpenSubtitles](https://opus.nlpl.eu/OpenSubtitles/corpus/version/OpenSubtitles)                                                             | Conversation | 271.60M     | [CC-0]                 |
-| [ai-aktindsigt]     | Multiple web scrapes from municipality websites collected as a part of the [AI-aktindsigt](https://ai-aktindsigt.dk) project                                      | Web          | 139.23M     | [Apache 2.0]           |
-| [miljoeportalen]    | Data from [Danmarks Miljøportalen](https://www.miljoeportal.dk/om-danmarks-miljoeportal/) (Denmark's Environment Portal)                                          | Web          | 127.38M     | [CC-0]                 |
-| [skat]              | Skat is the Danish tax authority. This dataset contains content from its website skat.dk                                                                          | Legal        | 122.11M     | [CC-0]                 |
-| [wiki]              | The Danish subsection of [wikipedia](https://en.wikipedia.org/wiki/Main_Page)                                                                                     | Encyclopedic | 122.00M     | [CC-0]                 |
-| [ft]                | Records from all meetings of The Danish parliament (Folketinget) in the parliament hall                                                                           | Conversation | 114.09M     | [CC-0]                 |
-| [ep]                | The Danish subsection of [Europarl](https://aclanthology.org/2005.mtsummit-papers.11/)                                                                            | Conversation | 100.84M     | [CC-0]                 |
-| [adl]               | Danish literature from 1700-2023 from the Archive for Danish Literature (ADL)                                                                                     | Books        | 58.49M      | [CC-0]                 |
-| [retspraksis]       | Case law or judical practice in Denmark derived from [Retspraksis](https://da.wikipedia.org/wiki/Retspraksis)                                                     | Legal        | 56.26M      | [CC-0]                 |
-| [fm-udgivelser]     | The official publication series of the Danish Ministry of Finance containing economic analyses, budget proposals, and fiscal policy documents                     | Legal        | 50.34M      | [CC-BY-SA 4.0]         |
-| [nordjyllandnews]   | Articles from the Danish Newspaper [TV2 Nord](https://www.tv2nord.dk)                                                                                             | News         | 37.90M      | [CC-0]                 |
-| [eur-lex-sum-da]    | The Danish subsection of EUR-lex SUM consisting of EU legislation paired with professionally written summaries                                                    | Legal        | 31.37M      | [CC-BY-SA 4.0]         |
-| [ncc_maalfrid]      | Danish content from Norwegian institutions websites                                                                                                               | Web          | 29.26M      | [NLOD 2.0]             |
-| [tv2r]              | Contemporary Danish newswire articles published between 2010 and 2019                                                                                             | News         | 21.67M      | [CC-BY-SA 4.0]         |
-| [memo]              | The MeMo corpus comprising almost all Danish novels from the period 1870-1899, known as the Modern Breakthrough                                                   | Books        | 9.28M       | [CC-BY-SA 4.0]         |
-| [danske-taler]      | Danish Speeches from [dansketaler.dk](https://www.dansketaler.dk)                                                                                                 | Conversation | 8.23M       | [CC-0]                 |
-| [nota]              | The text only part of the [Nota lyd- og tekstdata](https://sprogteknologi.dk/dataset/nota-lyd-og-tekstdata) dataset                                               | Readaloud    | 7.30M       | [CC-0]                 |
-| [gutenberg]         | The Danish subsection from Project [Gutenberg](https://www.gutenberg.org)                                                                                         | Books        | 6.76M       | [Gutenberg]            |
-| [wikibooks]         | The Danish Subsection of [Wikibooks](https://www.wikibooks.org)                                                                                                   | Books        | 6.24M       | [CC-0]                 |
-| [wikisource]        | The Danish subsection of [Wikisource](https://en.wikisource.org/wiki/Main_Page)                                                                                   | Encyclopedic | 5.34M       | [CC-0]                 |
-| [jvj]               | The works of the Danish author and poet, [Johannes V. Jensen](https://da.wikipedia.org/wiki/Johannes_V._Jensen)                                                   | Books        | 3.55M       | [CC-BY-SA 4.0]         |
-| [spont]             | Conversational samples collected as a part of research projects at Aarhus University                                                                              | Conversation | 1.56M       | [CC-0]                 |
-| [dannet]            | [DanNet](https://cst.ku.dk/projekter/dannet) is a Danish WordNet                                                                                                  | Other        | 1.48M       | [DanNet 1.0]           |
-| [relig]             | Danish religious text from the 1700-2022                                                                                                                          | Books        | 1.24M       | [CC-0]                 |
-| [ncc_newspaper]     | OCR'd Newspapers derived from [NCC](https://huggingface.co/datasets/NbAiLab/NCC)                                                                                  | News         | 1.05M       | [CC-0]                 |
-| [botxt]             | The Bornholmsk Ordbog Dictionary Project                                                                                                                          | Dialect      | 847.97K     | [CC-0]                 |
-| [naat]              | Danish speeches from 1930-2022                                                                                                                                    | Conversation | 286.68K     | [CC-0]                 |
-| [depbank]           | The Danish subsection of the [Universal Dependencies Treebank](https://github.com/UniversalDependencies/UD_Danish-DDT)                                            | Other        | 185.45K     | [CC-BY-SA 4.0]         |
-| [synne]             | Dataset collected from [synnejysk forening's website](https://www.synnejysk.dk), covering the Danish dialect sønderjysk                                           | Other        | 52.02K      | [CC-0]                 |
-| **Total**           |                                                                                                                                                                   |              | 4.26B       |                        |
+| Source              | Description                                                                                                                                                                            | Domain       | N. Tokens   | License                |
+|:--------------------|:---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|:-------------|:------------|:-----------------------|
+| [cellar]            | The official digital repository for European Union legal documents and open data                                                                                                       | Legal        | 1.15B       | [CC-BY-SA 4.0]         |
+| [ncc_books]         | Danish books extracted from the [Norwegian Colossal Corpus](https://huggingface.co/datasets/NbAiLab/NCC) derived from OCR                                                              | Books        | 531.97M     | [CC-0]                 |
+| [retsinformationdk] | [retsinformation.dk](https://www.retsinformation.dk) (legal-information.dk) the official legal information system of Denmark                                                           | Legal        | 516.35M     | [Danish Copyright Law] |
+| [hest]              | Samples from the Danish debate forum www.heste-nettet.dk                                                                                                                               | Social Media | 389.32M     | [CC-0]                 |
+| [ncc_parliament]    | Collections from the Norwegian parliament in Danish. Extracted from the [Norwegian Colossal Corpus](https://huggingface.co/datasets/NbAiLab/NCC) derived from ocr                      | Other        | 338.87M     | [NLOD 2.0]             |
+| [opensubtitles]     | Danish subsection of [OpenSubtitles](https://opus.nlpl.eu/OpenSubtitles/corpus/version/OpenSubtitles)                                                                                  | Conversation | 271.60M     | [CC-0]                 |
+| [ai-aktindsigt]     | Multiple web scrapes from municipality websites collected as a part of the [AI-aktindsigt](https://ai-aktindsigt.dk) project                                                           | Web          | 139.23M     | [Apache 2.0]           |
+| [miljoeportalen]    | Data from [Danmarks Miljøportalen](https://www.miljoeportal.dk/om-danmarks-miljoeportal/) (Denmark's Environment Portal)                                                               | Web          | 127.38M     | [CC-0]                 |
+| [skat]              | Skat is the Danish tax authority. This dataset contains content from its website skat.dk                                                                                               | Legal        | 122.11M     | [CC-0]                 |
+| [wiki]              | The Danish subsection of [wikipedia](https://en.wikipedia.org/wiki/Main_Page)                                                                                                          | Encyclopedic | 122.00M     | [CC-0]                 |
+| [ft]                | Records from all meetings of The Danish parliament (Folketinget) in the parliament hall                                                                                                | Conversation | 114.09M     | [CC-0]                 |
+| [memo]              | The MeMo corpus comprising almost all Danish novels from the period 1870-1899, known as the Modern Breakthrough                                                                        | Books        | 113.74M     | [CC-BY-SA 4.0]         |
+| [ep]                | The Danish subsection of [Europarl](https://aclanthology.org/2005.mtsummit-papers.11/)                                                                                                 | Conversation | 100.84M     | [CC-0]                 |
+| [adl]               | Danish literature from 1700-2023 from the [Archive for Danish Literature](https://tekster.kb.dk/text?editorial=no&f%5Bsubcollection_ssi%5D%5B%5D=adl&match=one&search_field=Alt) (ADL) | Books        | 58.49M      | [CC-0]                 |
+| [retspraksis]       | Case law or judical practice in Denmark derived from [Retspraksis](https://da.wikipedia.org/wiki/Retspraksis)                                                                          | Legal        | 56.26M      | [CC-0]                 |
+| [fm-udgivelser]     | The official publication series of the Danish Ministry of Finance containing economic analyses, budget proposals, and fiscal policy documents                                          | Legal        | 50.34M      | [CC-BY-SA 4.0]         |
+| [nordjyllandnews]   | Articles from the Danish Newspaper [TV2 Nord](https://www.tv2nord.dk)                                                                                                                  | News         | 37.90M      | [CC-0]                 |
+| [eur-lex-sum-da]    | The Danish subsection of EUR-lex SUM consisting of EU legislation paired with professionally written summaries                                                                         | Legal        | 31.37M      | [CC-BY-SA 4.0]         |
+| [ncc_maalfrid]      | Danish content from Norwegian institutions websites                                                                                                                                    | Web          | 29.26M      | [NLOD 2.0]             |
+| [tv2r]              | Contemporary Danish newswire articles published between 2010 and 2019                                                                                                                  | News         | 21.67M      | [CC-BY-SA 4.0]         |
+| [danske-taler]      | Danish Speeches from [dansketaler.dk](https://www.dansketaler.dk)                                                                                                                      | Conversation | 8.23M       | [CC-0]                 |
+| [nota]              | The text only part of the [Nota lyd- og tekstdata](https://sprogteknologi.dk/dataset/nota-lyd-og-tekstdata) dataset                                                                    | Readaloud    | 7.30M       | [CC-0]                 |
+| [gutenberg]         | The Danish subsection from Project [Gutenberg](https://www.gutenberg.org)                                                                                                              | Books        | 6.76M       | [Gutenberg]            |
+| [wikibooks]         | The Danish Subsection of [Wikibooks](https://www.wikibooks.org)                                                                                                                        | Books        | 6.24M       | [CC-0]                 |
+| [wikisource]        | The Danish subsection of [Wikisource](https://en.wikisource.org/wiki/Main_Page)                                                                                                        | Encyclopedic | 5.34M       | [CC-0]                 |
+| [jvj]               | The works of the Danish author and poet, [Johannes V. Jensen](https://da.wikipedia.org/wiki/Johannes_V._Jensen)                                                                        | Books        | 3.55M       | [CC-BY-SA 4.0]         |
+| [spont]             | Conversational samples collected as a part of research projects at Aarhus University                                                                                                   | Conversation | 1.56M       | [CC-0]                 |
+| [dannet]            | [DanNet](https://cst.ku.dk/projekter/dannet) is a Danish WordNet                                                                                                                       | Other        | 1.48M       | [DanNet 1.0]           |
+| [relig]             | Danish religious text from the 1700-2022                                                                                                                                               | Books        | 1.24M       | [CC-0]                 |
+| [ncc_newspaper]     | OCR'd Newspapers derived from [NCC](https://huggingface.co/datasets/NbAiLab/NCC)                                                                                                       | News         | 1.05M       | [CC-0]                 |
+| [botxt]             | The Bornholmsk Ordbog Dictionary Project                                                                                                                                               | Dialect      | 847.97K     | [CC-0]                 |
+| [naat]              | Danish speeches from 1930-2022                                                                                                                                                         | Conversation | 286.68K     | [CC-0]                 |
+| [depbank]           | The Danish subsection of the [Universal Dependencies Treebank](https://github.com/UniversalDependencies/UD_Danish-DDT)                                                                 | Other        | 185.45K     | [CC-BY-SA 4.0]         |
+| [synne]             | Dataset collected from [synnejysk forening's website](https://www.synnejysk.dk), covering the Danish dialect sønderjysk                                                                | Other        | 52.02K      | [CC-0]                 |
+| **Total**           |                                                                                                                                                                                        |              | 4.37B       |                        |
 
 [ai-aktindsigt]: data/ai-aktindsigt/ai-aktindsigt.md
 [cellar]: data/cellar/cellar.md

data/memo/create.py

@@ -2,107 +2,183 @@
 # requires-python = "==3.12"
 # dependencies = [
 #     "datasets==3.2.0",
+#     "dynaword"
 # ]
+# [tool.uv.sources]
+# dynaword = { git = "https://huggingface.co/datasets/danish-foundation-models/danish-dynaword", rev = "00e7f2aee7f7ad2da423419f77ecbb9c0536de0d" }
 # ///
-from datetime import datetime, timedelta
+"""
+Script for downloading and processing the Danish Memo repository.
+
+Note: To run this script, you need to set `GIT_LFS_SKIP_SMUDGE=1` to be able to install dynaword:
+
+```bash
+GIT_LFS_SKIP_SMUDGE=1 uv run data/memo/create.py
+```
+
+This second version fixed previous issues with the download and processing of the Danish Memo repository:
+https://huggingface.co/datasets/danish-foundation-models/danish-dynaword/discussions/67
+"""
+
+import logging
+import subprocess
+from datetime import datetime
 from pathlib import Path
-from typing import cast
-
-from datasets import Dataset, load_dataset
-
-column_order = [
-    "text",
-    "source",
-    "id",
-    "added",
-    "created",
-    "license",
-    "domain",
-    "metadata",
-]
-
-
-def convert_sample(example: dict) -> dict:
-    # from sample:
-    # {
-    #     "filename": "1894_Aagaard_UnderligeFyre",
-    #     "full_firstnames": "Oscar",
-    #     "auth_first": "Oscar",
-    #     "auth_last_modern": "Aagaard",
-    #     "pseudonym": None,
-    #     "publ_date": 1894,
-    #     "title_modern": "Underlige Fyre",
-    #     "published_under_gender": "male",
-    #     "real_gender": "male",
-    #     "nationality": "no",
-    #     "auth_id": 1,
-    #     "auth_last": "Aagaard",
-    #     "title": "Underlige Fyre",
-    #     "surname": "Aagaard",
-    #     "title.1": "Underlige Fyre",
-    #     "subtitle": "Fortælling",
-    #     "volume": None,
-    #     "year": 1894,
-    #     "pages": 263.0,
-    #     "illustrations": "n",
-    #     "typeface": "roman",
-    #     "publisher": "Gyldendal",
-    #     "price": 3.0,
-    #     "source": "KB",
-    #     "notes": None,
-    #     "filepath": None,
-    #     "historical": None,
-    #     "period": "nan",
-    #     "period_notes": "nan",
-    #     "novel_start": 13.0,
-    #     "novel_end": 275.0,
-    #     "serialno": 854.0,
-    #     "category": "O",
-    #     "e_canon": 0,
-    #     "ce_canon": 0,
-    #     "lex_canon": 0,
-    #     "text": "Første kapitel. Argus & co. Waterclerker — hvormange er der vel, ...",
-    # }
-
-    min_date = datetime.fromisoformat(f"{example["year"]}-01-01")
-    max_date = datetime.fromisoformat(f"{example["year"]}-12-31")
-    text = f"{example['title_modern']}\n\nSkrevet af {example['full_firstnames']} {example['auth_last_modern']}\nPubliceret {example['year']} af {example['publisher']}\n\n{example['text']}"
-
-    new_example = dict(
-        text_new=text,
-        id=example["filename"],
-        source="memo",
-        domain="Wiki & Books",
-        license="cc-by-sa-4.0",
-        added="2025-03-08",
-        created=f"{min_date.date()}, {max_date.date()}",
-        metadata={"source-pretty": "MeMo Canonical Novels"},
+from typing import Any
+
+import pandas as pd
+from datasets import Dataset
+
+from dynaword.process_dataset import (
+    add_token_count,
+    ensure_column_order,
+    remove_duplicate_text,
+    remove_empty_texts,
+)
+
+logger = logging.getLogger(__name__)
+
+download_path = Path(__file__).parent / "tmp"
+
+
+def download_repo(
+    download_path: Path = download_path,
+    repo_url: str = "https://huggingface.co/datasets/MiMe-MeMo/Corpus-v1.1",
+    revision="7205897f1f3ee65e296072f3e96d49488e54e8ce",
+) -> Path:
+    """
+    Downloads the repository from the given URL to the specified path.
+    """
+    logger.info(f"Downloading repository to {download_path}")
+    if not download_path.exists():
+        download_path.mkdir(parents=True, exist_ok=True)
+
+    repo_path = download_path / repo_url.split("/")[-1]
+    if repo_path.exists():
+        logger.info(f"Repository already exists at {repo_path}, skipping download.")
+        return repo_path
+
+    # Use git to clone the repository running it from the download path
+    subprocess.run(["git", "clone", repo_url], check=True, cwd=download_path)
+    # Checkout the specific revision
+    subprocess.run(["git", "checkout", revision], check=True, cwd=repo_path)
+    logger.info("Download complete.")
+    return repo_path
+
+
+def load_texts(repo_path: Path) -> list[dict[str, str]]:
+    """
+    Loads texts from the downloaded repository.
+    """
+    text_files_path = repo_path / "texts"
+    text_files = list(text_files_path.glob("*.txt"))
+    texts = []
+    for file in text_files:
+        name = file.stem
+        with file.open("r") as f:
+            content = f.read()
+            texts.append({"name": name, "text": content})
+    logger.info(f"Loaded {len(texts)} texts from the repository.")
+    return texts
+
+
+def load_memo(repo_path: Path) -> pd.DataFrame:
+    texts = load_texts(repo_path)
+
+    metadata_csv = repo_path / "MeMo-corpus-metadata-v1.1-2023-06-20.csv"
+    metadata = pd.read_csv(metadata_csv)
+    # remove .pdf from "filename"
+    metadata["filename"] = metadata["filename"].str.replace(".pdf", "", regex=False)
+    texts_df = pd.DataFrame(texts)
+
+    text_df_fileames = set(texts_df["name"])
+    metadata_filenames = set(metadata["filename"])
+
+    text_without_metadata = [t for t in text_df_fileames if t not in metadata_filenames]
+
+    assert (
+        len(text_without_metadata) == 0
+    ), f"Some texts in the repository do not have metadata: {text_without_metadata}"
+
+    # merge texts with metadata
+    merged_df = pd.merge(
+        texts_df, metadata, left_on="name", right_on="filename", how="inner"
     )
 
-    return new_example
+    logger.info(f"Loaded {len(merged_df)} rows from the MeMo dataset.")
+    return merged_df
 
 
-def main():
-    ds = load_dataset("chcaa/memo-canonical-novels", split="train")
-    ds = cast(Dataset, ds)
-    dates = [datetime.fromisoformat(f"{date}-01-01").date() for date in ds["year"]]
+def convert_to_dynaword_format(memo_df: pd.DataFrame) -> Dataset:
+    # convert to dynaword samples
+    samples: list[dict[str, Any]] = []
+    for _, row in memo_df.iterrows():
+        text = row["text"]
+        assert isinstance(text, str), f"Text is not a string: {text}"
+
+        # if there is a title then add it to the text
+        title = row["title"] if pd.notna(row["title"]) else "Ukendt titel"
+        subtitle = row["subtitle"] if pd.notna(row["subtitle"]) else ""
+        title = f"{title} {subtitle}".strip()
+
+        first_name = row["firstname"]
+        last_name = row["surname"]
+        pseudonym = row["pseudonym"]
+
+        full_name = f"{first_name} {last_name}".strip()
+        if not full_name:
+            full_name = pseudonym if pd.notna(pseudonym) else "Ukendt forfatter"
+        else:
+            # add pseudonym if it exists
+            if pd.notna(pseudonym) and pseudonym != full_name:
+                full_name += f" (Pseudonym: {pseudonym})"
 
-    max_date = max(dates) + timedelta(days=364)
-    print(str(min(dates)), ",", str(max_date))  # 1870-01-01 , 1899-12-31
+        # create a new text with the title and author
+        text_new = f"{title}\n\nSkrevet af {full_name}\nPubliceret {row['year']} af {row['publisher']}\n ------- \n\n{text}"
 
-    assert len(set(ds["filename"])) == len(ds), "IDs are not unique"
-    assert len(set(ds["text"])) == len(ds), "Texts are not unique"
+        today = datetime.now().date()
+        sample = {
+            "id": row["filename"],
+            "text": text_new,
+            "source": "memo",
+            "added": today.isoformat(),
+            "created": f"{row['year']}-01-01, {row['year']}-12-31",
+        }
 
-    ds = ds.map(convert_sample, num_proc=4)
-    ds = ds.select_columns(column_order[1:] + ["text_new"])
-    ds = ds.rename_columns({"text_new": "text"})
-    # ensure order
-    ds = ds.select_columns(column_order)
+        samples.append(sample)
 
-    dir = Path(__file__).parent
-    save_path = dir / f"{dir.name}.parquet"
+    ds = Dataset.from_list(samples)
+    logger.info(f"Converted to dynaword format with {len(ds)} samples.")
+    return ds
+
+    ds = convert_to_dynaword_format(memo_df)
+
+
+def main():
+    save_path = Path(__file__).parent / "memo.parquet"
+
+    repo_path = download_repo(download_path)
+    memo_df = load_memo(repo_path)
+    ds = convert_to_dynaword_format(memo_df)
+
+    # quality checks and processing
+    ds = remove_empty_texts(ds)
+    ds = remove_duplicate_text(ds)
+    ds = add_token_count(ds)
+    ds = ensure_column_order(ds)
+
+    # save to parquet
     ds.to_parquet(save_path)
 
 
 if __name__ == "__main__":
+    log_path = Path(__file__).parent / "memo.log"
+    logging.basicConfig(
+        level=logging.INFO,
+        format="%(asctime)s - %(levelname)s - %(message)s",
+        handlers=[
+            logging.StreamHandler(),
+            logging.FileHandler(log_path),
+        ],
+    )
     main()

data/memo/descriptive_stats.json

@@ -1,6 +1,6 @@
 {
-  "number_of_samples": 839,
-  "average_document_length": 32813.50774731824,
-  "number_of_tokens": 9283194,
-  "revision": "1546256ca9562ecef403e433276c36770859089e"
+  "number_of_samples": 858,
+  "average_document_length": 375749.0874125874,
+  "number_of_tokens": 113742425,
+  "revision": "9e941ac4e56b7b77ec77b84a3a40130ba78a9511"
 }

data/memo/memo.log

@@ -0,0 +1,20 @@
+2025-06-23 15:14:07,867 - INFO - Downloading repository to /Users/au561649/Github/danish-dynaword/data/memo/tmp
+2025-06-23 15:14:07,867 - INFO - Repository already exists at /Users/au561649/Github/danish-dynaword/data/memo/tmp/Corpus-v1.1, skipping download.
+2025-06-23 15:14:19,489 - INFO - Loaded 858 texts from the repository.
+2025-06-23 15:14:19,512 - INFO - Loaded 858 rows from the MeMo dataset.
+2025-06-23 15:14:20,848 - INFO - Converted to dynaword format with 858 samples.
+2025-06-23 15:14:20,903 - INFO - Removing empty texts
+2025-06-23 15:14:25,977 - INFO - Filtered 0 empty examples
+2025-06-23 15:14:25,977 - INFO - Removing duplicate texts
+2025-06-23 15:14:26,434 - INFO - Filtered 0 duplicate examples
+2025-06-23 15:15:40,637 - INFO - Ensuring columns are in the correct order and are present
+2025-06-23 15:33:08,880 - INFO - Downloading repository to /Users/au561649/Github/danish-dynaword/data/memo/tmp
+2025-06-23 15:33:08,880 - INFO - Repository already exists at /Users/au561649/Github/danish-dynaword/data/memo/tmp/Corpus-v1.1, skipping download.
+2025-06-23 15:33:19,998 - INFO - Loaded 858 texts from the repository.
+2025-06-23 15:33:20,025 - INFO - Loaded 858 rows from the MeMo dataset.
+2025-06-23 15:33:21,332 - INFO - Converted to dynaword format with 858 samples.
+2025-06-23 15:33:21,373 - INFO - Removing empty texts
+2025-06-23 15:33:25,745 - INFO - Filtered 0 empty examples
+2025-06-23 15:33:25,746 - INFO - Removing duplicate texts
+2025-06-23 15:33:26,174 - INFO - Filtered 0 duplicate examples
+2025-06-23 15:34:37,788 - INFO - Ensuring columns are in the correct order and are present

data/memo/memo.md

@@ -23,23 +23,16 @@ The MeMo corpus comprising almost all Danish novels from the period 1870-1899, k
 
 The MeMo corpus is established to investigate literary and cultural change in a seminal epoch of Scandinavian cultural and social history (known as 'the modern breakthrough') using natural language processing and other computational methods. The corpus consists of original novels by Norwegian and Danish authors printed in Denmark in the period 1870-99. It includes 858 volumes, totaling 4.5 million sentences and 65 million words.
 
-
-Lex.dk is a Danish online encyclopedia platform providing access to reliable and authoritative knowledge on a wide range of topics. It is created and curated by experts, ensuring high-quality, accurate content. The platform serves as a central hub for general and specialized information in Danish, making it a valuable resource for education, research, and general learning.
-
-
-Additional information about this dataset can be found on their [project page](https://nors.ku.dk/english/research/projects/measuring-modernity/) or on their huggingface [dataset](https://huggingface.co/datasets/MiMe-MeMo/Corpus-v1.1).
-
-
-
+Additional information about this dataset can be found on their [project page](https://nors.ku.dk/english/research/projects/measuring-modernity/) or on their huggingface [dataset](https://huggingface.co/datasets/MiMe-MeMo/Corpus-v1.1). The dataset can be inspected online using [the Korp platform](https://alf.hum.ku.dk/korp/?mode=memo_all#?cqp=%5B%5D&corpus=memo_all).
 
 ## Dataset Description
 
 <!-- START-DESC-STATS -->
 - **Language**: dan, dansk, Danish
 - **Domains**: Books
-- **Number of samples**: 839
-- **Number of tokens (Llama 3)**: 9.28M
-- **Average document length (characters)**: 32813.51
+- **Number of samples**: 858
+- **Number of tokens (Llama 3)**: 113.74M
+- **Average document length (characters)**: 375749.09
 <!-- END-DESC-STATS -->
 
 
@@ -49,12 +42,12 @@ An example from the dataset looks as follows.
 <!-- START-SAMPLE -->
 ```py
 {
-  "id": "1894_Aagaard_UnderligeFyre",
-  "text": "Underlige Fyre\n\nSkrevet af Oscar Aagaard\nPubliceret 1894 af Gyldendal\n\nFørste kapitel. Argus & co. W[...]",
+  "id": "1887_Paulsen_EnFremtidskvinde",
+  "text": "En fremtidskvinde?\n\nSkrevet af John Paulsen\nPubliceret 1887 af Schubothe\n ------- \n\nDen skandinavisk[...]",
   "source": "memo",
-  "added": "2025-03-08",
-  "created": "1894-01-01, 1894-12-31",
-  "token_count": 11058
+  "added": "2025-06-23",
+  "created": "1887-01-01, 1887-12-31",
+  "token_count": 98454
 }
 ```
 
@@ -79,6 +72,15 @@ An entry in the dataset consists of the following fields:
 </p>
 <!-- END-DATASET PLOTS -->
 
+### Processing
+
+In addition to the text itself we prefix the document with the title, year, author name, pseudonym and publisher. This is to allow the model to learn the relation between the document and relevant metadata.
+
+
+### Updated and Corrections
+
+This version fixed a previous [issues]( https://huggingface.co/datasets/danish-foundation-models/danish-dynaword/discussions/67) in MeMo where the documents where incorrectly truncated and normalized. Removing this truncation led to a >10x increase in number of tokens. 
+
 
 ## Additional Information
 

data/memo/memo.parquet

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:8f818bfe699c81cdb61ffdf260d8d3407118d295e61f596b1e28d100b6c5067d
-size 17799996
+oid sha256:44002e00b3e876bb6ebd70949723a08310bb022e4e91502c5ec7a64efb6d4706
+size 202092223

descriptive_stats.json

@@ -1,6 +1,6 @@
 {
-  "number_of_samples": 891075,
-  "average_document_length": 14755.728222652415,
-  "number_of_tokens": 4264549097,
-  "revision": "1b6610f644fd8ab48414ddb77c5e1cbb53e64b04"
+  "number_of_samples": 891094,
+  "average_document_length": 15086.31267857263,
+  "number_of_tokens": 4369008328,
+  "revision": "9e941ac4e56b7b77ec77b84a3a40130ba78a9511"
 }

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "dynaword"
-version = "1.1.1"
+version = "1.2.0"
 description = "project code for the danish dynaword project"
 readme = "README.md"
 requires-python = ">=3.12,<3.13" # 3.13 have issues with spacy and pytorch

src/tests/test_quality/test_duplicates.py

@@ -6,6 +6,7 @@ from datasets import Dataset, load_dataset
 from dynaword.paths import repo_path
 from ..conftest import DATASET_NAMES
 
+
 @pytest.mark.parametrize("dataset_name", DATASET_NAMES)
 def test_no_within_data_duplicates(dataset_name: str):
     ds = load_dataset(str(repo_path.resolve()), dataset_name, split="train")

test_results.log

@@ -2,15 +2,24 @@
 platform darwin -- Python 3.12.0, pytest-8.3.4, pluggy-1.5.0
 rootdir: /Users/au561649/Github/danish-dynaword
 configfile: pyproject.toml
-collected 276 items
+plugins: anyio-4.9.0
+collected 310 items
 
-src/tests/test_dataset_schema.py ....................................... [ 14%]
-.............................                                            [ 24%]
-src/tests/test_datasheets.py ........................................... [ 40%]
-........................................................................ [ 66%]
-.......................................................                  [ 86%]
-src/tests/test_duplicates.py ..................................s         [ 98%]
-src/tests/test_load.py ..                                                [ 99%]
+src/tests/test_dataset_schema.py ....................................... [ 12%]
+.............................                                            [ 21%]
+src/tests/test_datasheets.py ........................................... [ 35%]
+........................................................................ [ 59%]
+.......................................................                  [ 76%]
+src/tests/test_load.py ..                                                [ 77%]
+src/tests/test_quality/test_duplicates.py .............................. [ 87%]
+....s                                                                    [ 88%]
+src/tests/test_quality/test_short_texts.py ............................. [ 98%]
+.....                                                                    [ 99%]
 src/tests/test_unique_ids.py .                                           [100%]
 
-======================= 275 passed, 1 skipped in 54.24s ========================
+=============================== warnings summary ===============================
+src/tests/test_quality/test_short_texts.py: 34 warnings
+  /Users/au561649/Github/danish-dynaword/.venv/lib/python3.12/site-packages/datasets/utils/_dill.py:385: DeprecationWarning: co_lnotab is deprecated, use co_lines instead.
+
+-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
+============ 309 passed, 1 skipped, 34 warnings in 77.84s (0:01:17) ============